-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #29093 - change from superficial copy to deep copy of fields #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adiabramovitch ,
Notice that the hammer_cli_foreman tests are failing with this error:
@@ -11,7 +11,8 @@ def initialize(options = {}) | |||
@all = [] | |||
@children = [] | |||
@options = options | |||
@creator = options[:creator] || Class.new(HammerCLI::Apipie::Command) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I'm currently working on a little bit different approach for option creation and this anonymous class will disappear :) So, 👍 for the solution, but it should wait a bit before we get rid of this class.
d317cb7
to
8509efd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adiabramovitch! Since this change doesn't break tests for plugins anymore we can finally merge it :)
Looks like this broke nightly again, just like in #345 (comment): https://ci.theforeman.org/job/foreman-nightly-rpm-pipeline/1160/tapResults/
|
|
Thanks! |
No description provided.