Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising ProxyAddHeaders #952

Closed
nbarrientos opened this issue May 12, 2021 · 0 comments · Fixed by #953
Closed

Allow customising ProxyAddHeaders #952

nbarrientos opened this issue May 12, 2021 · 0 comments · Fixed by #953

Comments

@nbarrientos
Copy link
Contributor

nbarrientos commented May 12, 2021

When the Apache instance configured by this module is not dealing with user requests directly because there's another proxy in front, it's undesirable that the "local" Apache resets headers like X-Forwarded-Host. When it does, it could happen that links created using Rails _url helpers do not contain the Host initially sent by the client leading to broken links (as they point to backend nodes not reachable by the user).

The task is to make this configurable by adding a parameter to foreman::config::apache.

nbarrientos added a commit to nbarrientos/puppet-foreman that referenced this issue May 12, 2021
When the Apache instance configured by this module is not dealing with
user requests directly because there's another proxy in front, it's
undesirable that the "local" Apache resets headers like
X-Forwarded-Host. When it does, it could happen that links created
using Rails _url helpers do not contain the Host initially sent by the
client leading to broken links (as they point to backend nodes not
reachable by the user).

This patch makes this setting customisable by the administrator by
exposing it a parameter.

Fixes theforeman#952
nbarrientos added a commit to nbarrientos/puppet-foreman that referenced this issue May 12, 2021
When the Apache instance configured by this module is not dealing with
user requests directly because there's another proxy in front, it's
undesirable that the "local" Apache resets headers like
X-Forwarded-Host. When it does, it could happen that links created
using Rails _url helpers do not contain the Host initially sent by the
client leading to broken links (as they point to backend nodes not
reachable by the user).

This patch makes this setting customisable by the administrator by
exposing it a parameter.

Fixes theforeman#952
ekohl pushed a commit that referenced this issue May 12, 2021
When the Apache instance configured by this module is not dealing with
user requests directly because there's another proxy in front, it's
undesirable that the "local" Apache resets headers like
X-Forwarded-Host. When it does, it could happen that links created
using Rails _url helpers do not contain the Host initially sent by the
client leading to broken links (as they point to backend nodes not
reachable by the user).

This patch makes this setting customisable by the administrator by
exposing it a parameter.

Fixes #952
cegeka-jenkins pushed a commit to cegeka/puppet-foreman that referenced this issue Feb 3, 2022
When the Apache instance configured by this module is not dealing with
user requests directly because there's another proxy in front, it's
undesirable that the "local" Apache resets headers like
X-Forwarded-Host. When it does, it could happen that links created
using Rails _url helpers do not contain the Host initially sent by the
client leading to broken links (as they point to backend nodes not
reachable by the user).

This patch makes this setting customisable by the administrator by
exposing it a parameter.

Fixes theforeman#952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant