Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #34824 - properly restart foreman when puma config changed #1045

Merged
merged 1 commit into from
Apr 27, 2022

Commits on Apr 27, 2022

  1. Fixes #34824 - properly restart foreman when puma config changed

    we need to restart foreman.service *before* a (possible) restart of
    foreman.socket, as the later *also* does restart foreman.service which
    leads to foreman.socket being *started* instead of *restarted*
    
        /Service[foreman.socket]: Starting to evaluate the resource (2265 of 2522)
        Executing: '/bin/systemctl is-active -- foreman.socket'
        Executing: '/bin/systemctl restart -- foreman.socket'
        /Service[foreman]: Starting to evaluate the resource (2266 of 2522)
        Executing: '/bin/systemctl is-active -- foreman'
        Executing: '/bin/systemctl show --property=NeedDaemonReload -- foreman'
        Executing: '/bin/systemctl daemon-reload'
        Executing: '/bin/systemctl unmask -- foreman'
        Executing: '/bin/systemctl start -- foreman'
        Executing: '/bin/systemctl is-enabled -- foreman'
        /Stage[main]/Foreman::Service/Service[foreman]/ensure: ensure changed 'stopped' to 'running'
    
    But in this case the now running foreman.service didn't see the changes
    to the service file that daemon-reload would have loaded.
    evgeni committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    f12b52d View commit details
    Browse the repository at this point in the history