Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hammer plugin for ssh #1076

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Add hammer plugin for ssh #1076

merged 1 commit into from
Aug 25, 2022

Conversation

dgoetz
Copy link
Member

@dgoetz dgoetz commented Aug 17, 2022

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests?

['ansible', 'azure', 'discovery', 'host_reports', 'katello', 'kubevirt', 'openscap', 'remote_execution', 'tasks', 'templates', 'virt_who_configure', 'webhooks', 'puppet'].each do |plugin|

if $facts['os']['family'] == 'RedHat' {
include foreman::cli::ansible
include foreman::cli::azure
}
include foreman::cli::discovery
include foreman::cli::host_reports
include foreman::cli::remote_execution
include foreman::cli::tasks
include foreman::cli::templates
include foreman::cli::webhooks
include foreman::cli::puppet
PUPPET
end
end
it_behaves_like 'hammer'
['discovery', 'host_reports', 'remote_execution', 'tasks', 'templates', 'webhooks', 'puppet'].each do |plugin|

@dgoetz
Copy link
Member Author

dgoetz commented Aug 17, 2022

Added the tests and they are still running but first already finished and its looking good.

@ekohl ekohl merged commit 007ab1a into theforeman:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants