Ensure Foreman is provisioned before configuring cockpit #835
Conversation
| @@ -48,6 +48,7 @@ | |||
| } | |||
|
|
|||
| foreman_config_entry { 'remote_execution_cockpit_url': | |||
| value => "${cockpit_path}/=%{host}", | |||
| value => "${cockpit_path}/=%{host}", | |||
| require => Class['foreman::database'], | |||
There was a problem hiding this comment.
Does this ensure that all of the class has executed before this will execute? e.g. db:seed
There was a problem hiding this comment.
Yes, those resources are contained within the class (if they're managed).
There was a problem hiding this comment.
Thanks, I just loose track of puppet and how it build it's dependency cycle. Sounds like we could clean this up a bit?
https://github.com/theforeman/puppet-katello/blob/master/manifests/application.pp#L36
There was a problem hiding this comment.
Yes, that would be better. I've had a look at doing this in the type definition, but since the config part is also used within that, we can't always require the class.
|
Looks like we need to use the SCL postgres due to Rails 6. I'll update #699 |
|
What's ETA here? This is blocking QE automation. Can we expect it to be in presnap 0.2 ? |
|
@ekohl please rebase :) |
Previously foreman_config_entry could be executed before the database was available. This ensures the database is ready and the plugin installed before attempting to change a config setting.
Previously foreman_config_entry could be executed before the database was available. This ensures the database is ready and the plugin installed before attempting to change a config setting.