-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add foreman_statistics plugin #855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let Travis finish, but otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, speaking of Travis, could you add a spec test like in https://github.com/theforeman/puppet-foreman/tree/master/spec/classes/plugin
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go Travis! Go! :)
This failure does not seem to be related:
|
Correct, we've seen that every now and then. It happens when dynflow is too slow to start. https://projects.theforeman.org/issues/30275 is open and Adam started to look into it, but switching the autoloader to zeitwerk proved to be non-trivial. If you're interested in helping, theforeman/foreman#7843 is the current draft. |
Packaging PRs (should get merged first):