Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foreman_statistics plugin #855

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

ezr-ondrej
Copy link
Member

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Travis finish, but otherwise 👍

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, speaking of Travis, could you add a spec test like in https://github.com/theforeman/puppet-foreman/tree/master/spec/classes/plugin

@ezr-ondrej
Copy link
Member Author

Oh, speaking of Travis, could you add a spec test like in https://github.com/theforeman/puppet-foreman/tree/master/spec/classes/plugin

Done :)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Travis! Go! :)

@tbrisker
Copy link
Member

tbrisker commented Aug 3, 2020

This failure does not seem to be related:

1) Scenario: install foreman with journald Command "journalctl -u dynflow-sidekiq@orchestrator" stdout is expected to match /Everything ready for world: /

     Failure/Error: its(:stdout) { is_expected.to match(%r{Everything ready for world: }) }

       expected "-- Logs begin at Mon 2020-08-03 12:31:32 UTC, end at Mon 2020-08-03 12:42:36 UTC. --\nAug 03 12:36:5...:42:27 ubuntu1804-64.example.com foreman[4327]: Acquired orchestrator lock, entering active mode.\n" to match /Everything ready for world: /

@ekohl
Copy link
Member

ekohl commented Aug 3, 2020

Correct, we've seen that every now and then. It happens when dynflow is too slow to start. https://projects.theforeman.org/issues/30275 is open and Adam started to look into it, but switching the autoloader to zeitwerk proved to be non-trivial. If you're interested in helping, theforeman/foreman#7843 is the current draft.

@ekohl ekohl merged commit 705ae08 into theforeman:master Aug 3, 2020
@ezr-ondrej ezr-ondrej deleted the statistics branch August 3, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants