Allow customising the list of HTTP headers to unset #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patchset adds a new parameter to `foreman::config::apache` called `request_headers_to_unset` containing a list of HTTP headers to be unset before proxy passing the request to the application. See the associated issue for more information. Fixes theforeman#941
ekohl
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Please let me know if you'd rather to have the parameter exposed via
init.ppinstead.
I actually prefer it here. This can be considered advanced and only allowing that setting that via Hiera is good. This also makes it easy to set additional headers if we need to in the future. 👍
I've just started the tests and they should pass before merging. IMHO only waiting on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset adds a new parameter to
foreman::config::apachecalledrequest_headers_to_unsetcontaining a list of HTTP headers to be unset before proxy passing the request to the application. See theassociated issue for more information.
Please let me know if you'd rather to have the parameter exposed via
init.ppinstead.Fixes #941