Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Puppet 5 support #958

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Drop Puppet 5 support #958

merged 1 commit into from
Jul 5, 2021

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jun 1, 2021

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit was only needed until SERVER-2597 was fixed. That was part of Puppetserver 6.10.0 which we can pretty much assume if 6.15.0 is the minimal version. In theory the server could be older, but I don't think we need to support that.

# Puppetserver doesn't implement HTTP auth on get requests
# https://tickets.puppetlabs.com/browse/SERVER-2597
if defined?(Puppet::Server::HttpClient) && conn.is_a?(Puppet::Server::HttpClient) && options[:basic_auth]
require 'base64'
encoded = Base64.strict_encode64("#{options[:basic_auth][:user]}:#{options[:basic_auth][:password]}")
headers["Authorization"] = "Basic #{encoded}"
end

It can be dropped since the basic auth option is passed correctly in the request.

@ekohl ekohl merged commit a47e760 into theforeman:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants