Handle duplicate file declaration for foreman::app_root #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we're using your modul to install and configure Foreman. We want to install Foreman in its own filesystem, but the file ressource for $foreman::app_root makes it hard to implement this in puppet - it will always result in duplicate ressource. Furthermore i'm not sure, if this ressource is necessary or placed in the right class (ordering, first install the package and then create the directory?!). Testing if this directory is already defined gives other the chance to do some stuff, e.g. creating a filesystem before installing foreman :)
ekohl
approved these changes
Jul 8, 2021
ekohl
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Furthermore i'm not sure, if this ressource is necessary or placed in the right class (ordering, first install the package and then create the directory?!).
Normally the package install creates the directory. So the whole definition may not be needed. So I wonder why you want to manage this in a different way.
ekohl
approved these changes
Jul 22, 2021
ekohl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're using your modul to install and configure Foreman.
We want to install Foreman in its own filesystem, but the file ressource for $foreman::app_root makes it hard to implement this in puppet - it will always result in duplicate ressource. Furthermore i'm not sure, if this ressource is necessary or placed in the right class (ordering, first install the package and then create the directory?!).
Testing if this directory is already defined gives other the chance to do some stuff, e.g. creating a filesystem before installing foreman :)