Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33511 - configure redis before dynflow workers #995

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 17, 2021

sometimes dynflow workers are started before redis, resulting in ugly
errors in the logs until redis is available

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Would be nice to have a test. For example here:

it { is_expected.to contain_service('dynflow-sidekiq@orchestrator').with_ensure('running').with_enable(true) }
it { is_expected.to contain_service('dynflow-sidekiq@worker-1').with_ensure('running').with_enable(true) }

I think adding .that_requires('Service[redis]') would work.

@evgeni evgeni force-pushed the configure-redis-before-dynflow branch from b2ad6e3 to c43d0ef Compare September 17, 2021 10:25
@evgeni
Copy link
Member Author

evgeni commented Sep 17, 2021

I think adding .that_requires('Service[redis]') would work.

Narrator: it did not.

@evgeni
Copy link
Member Author

evgeni commented Sep 17, 2021

Should it be Class[redis], as we never touch Service[redis] in the order assignment?

@ekohl
Copy link
Member

ekohl commented Sep 17, 2021

The service name is dynamic so on EL7 it'll be different. Depending on the Class is good enough then.

@evgeni evgeni force-pushed the configure-redis-before-dynflow branch from c43d0ef to f2e480e Compare September 17, 2021 10:47
@evgeni evgeni changed the title configure redis before dynflow workers Fixes #33511 - configure redis before dynflow workers Sep 17, 2021
sometimes dynflow workers are started before redis, resulting in ugly
errors in the logs until redis is available
@evgeni evgeni force-pushed the configure-redis-before-dynflow branch from f2e480e to 7852ed5 Compare September 17, 2021 11:43
@evgeni evgeni merged commit d84fb8e into theforeman:master Sep 17, 2021
@evgeni evgeni deleted the configure-redis-before-dynflow branch September 17, 2021 12:28
@ehelms ehelms added the Bug label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants