Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concept sets for UC1 tables 5.15 - 5.19 & UC3 tables #5

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

LP-Glueck
Copy link

Variables from UC3 have been added as csv files to phems_variables_list directory also in this PR.

I still need to finish the drug mappings as we don't have all the possible mappings specified for the Factor VIII treatment variable (There can be potentially a lot). I will check if descendants can be used at all, but I think I will have to specify all possible drug mappings that we gave them as options because they are not subsumes of each other.

… UC3 csv files to phems_variables_list directory
Copy link

@SofiaMp SofiaMp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some concepts that can change. Only minor things. I understand that the csv files would need to be updated but I did not add the comments there.

project/R/conceptSets.R Outdated Show resolved Hide resolved
project/R/conceptSets.R Outdated Show resolved Hide resolved
project/R/conceptSets.R Outdated Show resolved Hide resolved
project/R/conceptSets.R Outdated Show resolved Hide resolved
project/R/conceptSets.R Outdated Show resolved Hide resolved
project/R/conceptSets.R Outdated Show resolved Hide resolved
project/R/conceptSets.R Outdated Show resolved Hide resolved
@LP-Glueck
Copy link
Author

Ready for review with updated changes 👍🏼

@guuswilmink
Copy link
Collaborator

guuswilmink commented Jul 19, 2024

Please add some comments to the conceptSets to indicate the source table from D4.1
For example for vital signs;

#  5.22 Vital Signs
vitalSigns = c(
  ...  # source: <> \\\ concept: <>
)

Other than that looks good! You can merge after this change

adding table names to concept sets
@LP-Glueck LP-Glueck merged commit 0463e30 into main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants