Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type checking with Mypy #347

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Improve type checking with Mypy #347

merged 2 commits into from
Jul 14, 2021

Conversation

bbc2
Copy link
Collaborator

@bbc2 bbc2 commented Jul 14, 2021

No description provided.

Mypy would complain about the missing `types-mock` package, which it now
needs to perform accurate type checking and despite
`ignore_missing_imports` set to `True`:

    tests/test_ipython.py:3: error: Library stubs not installed for "mock" (or incompatible with Python 3.9)
    tests/test_ipython.py:3: note: Hint: "python3 -m pip install types-mock"
    tests/test_ipython.py:3: note: (or run "mypy --install-types" to install all missing stub packages)
    tests/test_ipython.py:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
    tests/test_main.py:7: error: Library stubs not installed for "mock" (or incompatible with Python 3.9)
    Found 2 errors in 2 files (checked 15 source files)
@bbc2 bbc2 self-assigned this Jul 14, 2021
`set_key` and `unset_key` were more restrictive than other functions
such as `dotenv_values` with regards to their `dotenv_path` argument.
@bbc2 bbc2 merged commit 955e2a4 into theskumar:master Jul 14, 2021
@bbc2 bbc2 deleted the fix-mypy branch July 14, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant