Improve somepath --hidden behaviour #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an unintuitive case where
plz query somepathfinds a path butplz query somepath --hiddendoesn't (and the non-hidden version didn't really explain to me what was going on). This was somewhat intentional (with--hiddenyou were supposed to specify the exact coordinates at either end) but it was surprising and I think probably unhelpful.This simplifies things quite a bit so it always constructs a path of potentially hidden targets then collapses them out afterwards if appropriate.
Technically it's a slight change of behaviour but I think it's just better this way.