Download all inputs when running plz test & plz cover #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up for thought-machine#3066
janhancic
commented
Feb 8, 2024
| @@ -1301,7 +1301,6 @@ func (state *BuildState) GetPreloadedSubincludes() []BuildLabel { | |||
|
|
|||
| // DownloadInputsIfNeeded downloads all the inputs (or runtime files) for a target if we are building remotely. | |||
| func (state *BuildState) DownloadInputsIfNeeded(target *BuildTarget, runtime bool) error { | |||
| // TODO(jan): Remove this function once `DownloadAllInputs` has been fully implemented across both build & test. | |||
There was a problem hiding this comment.
I've removed this TODO as it looks like this is actually still used in a few other places. I'd like to discuss this when we have a chance because I think it highlighted another gap in my understanding; so I'd like to plug that but it isn't crucial for us to resolve this for the purposes of fixing the --shell issue.
Tatskaari
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #3066