upgrade v1+ libraries #3098
Merged
upgrade v1+ libraries #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
approved these changes
Mar 7, 2024
| @@ -56,7 +56,7 @@ func Push(config *core.Configuration) { | |||
|
|
|||
| if err := push.New(config.Metrics.PrometheusGatewayURL, "please"). | |||
| Client(&http.Client{Timeout: time.Duration(config.Metrics.Timeout)}). | |||
| Gatherer(prometheus.DefaultGatherer).Format(expfmt.FmtText). | |||
| Gatherer(prometheus.DefaultGatherer).Format(expfmt.NewFormat(expfmt.TypeTextPlain)). | |||
There was a problem hiding this comment.
Makes sense to leave this for now although I also wonder why we're actually setting this - I assume we could push in the default proto format just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading all go third_party libraries if they are in v1 or above. We have to upgrade some v0 libraries which are dependencies.