Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query commands take subrepos into account #3124

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

peterebden
Copy link
Member

@peterebden peterebden commented Apr 10, 2024

e.g.

$ plz query revdeps //third_party/go:golang.org_x_text
<nothing>

but that doesn't seem a particularly intuitive or useful result; clearly it is depended on (if you remove that thing, it doesn't build). now it shows:

$ plz plz query revdeps //third_party/go:golang.org_x_text
///third_party/go/golang.org_x_text//secure/bidirule:bidirule
///third_party/go/golang.org_x_text//transform:transform
///third_party/go/golang.org_x_text//unicode/bidi:bidi
///third_party/go/golang.org_x_text//unicode/norm:norm

I can't see a particularly sensible way of doing this systematically (I don't think targets should get explicit dependencies on them for this), so this just spot-fixes several of the query subcommands.

@peterebden peterebden mentioned this pull request Apr 11, 2024
@peterebden peterebden merged commit a3c23e8 into thought-machine:master Apr 12, 2024
13 of 14 checks passed
@peterebden peterebden deleted the go-repo-revdeps branch April 12, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant