Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local paths only for determining changes #3139

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Use local paths only for determining changes #3139

merged 2 commits into from
Apr 25, 2024

Conversation

peterebden
Copy link
Member

I think this is a better version of #3137

  • If sources are local to the package, we don't need to compare their package part.
  • If they're off the PATH, we don't need to worry about the PATH changing (that's handled elsewhere) so their name is enough
  • Build labels are excluded from this check in sourceHash anyway.

Hence this should be fine, and removes the possibility of them panicking.

Tatskaari
Tatskaari approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Tatskaari Tatskaari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense :) nice one

@peterebden peterebden merged commit 0c87ebf into thought-machine:master Apr 25, 2024
14 checks passed
@peterebden peterebden deleted the handle-paths-betterer branch April 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatskaari Tatskaari Tatskaari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterebden @Tatskaari