Convert TRTemperature to Temperature #141
Conversation
|
|
||
| self.highTemperature = [[Temperature alloc] initWithFahrenheitValue:[JSON[@"temperatureMax"] integerValue]]; | ||
| self.lowTemperature = [[Temperature alloc] initWithFahrenheitValue:[JSON[@"temperatureMin"] integerValue]]; | ||
|
I did improvements and pushed with -f option. I hope Circle CI will handle the updated commit. Also rebased. |
|
Something failed but not related to tests. Works locally as should work. |
| } | ||
|
|
||
| // MARK: NSObjectProtocol | ||
| override var description: String { |
There was a problem hiding this comment.
Let's go ahead and say this class conforms to Printable while we're at it. When we're swift only, it might be nice to be able to interpolate this.
There was a problem hiding this comment.
I don't know if I get your message correctly (correct me if wrong) but we inherits from NSObject now and this is the correct solution for now. When we finally move to swift all the code and Temperature class will not need to be visible in Objective-C code then we can drop NSObject inheritance and use Printable instead.
There was a problem hiding this comment.
I believe he's saying to also add Printable now so that we don't have to worry about adding it in the future.
There was a problem hiding this comment.
Yeah, that makes sense. Added.
|
@jakecraige @tonyd256 |
| @@ -1,6 +1,6 @@ | |||
| @import CoreLocation; | |||
| #import "TRWeatherUpdate.h" | |||
| #import "TRTemperature.h" | |||
| #import "UnitTests-Swift.h" | |||
There was a problem hiding this comment.
Yes it is. This is umbrella header which contains headers for Temperature class for Objective-C. Everywhere where Swift class is used in Objective-C we have to import this one in testing or "Tropos-Swift.h" in Tropos target. This will be dropped in the future when all will be in Swift ;)
There was a problem hiding this comment.
Awesome. Thanks for the info.
|
@jakecraige, improved the code. |
|
Thanks @tomkowz it all looks good to me now. Even CircleCI is passing now. I wonder if they were having trouble earlier if if something you changed fixed it. Either way it's green! Merged 👍 |
|
Cool ;) Will prepare another things to review for you guys so you're not bored ;) |
Converted class to Swift.