Fix merging of Buffer objects
#100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you attempted to `build`/`create` an object whose properties contained `Buffer`s, they would be converted from the native `Buffer` type into an array (and thus creating an _incorrect_ value). This is caused by the use of lodash's `merge` implementation (see lodash/lodash#2964). The recommended solution from the lodash project is to define a merge `customizer` to specifically handle this situation, which is what we do here.
|
Having the same problem with |
fix: pull recent changes and support TypedArray instances as well as Buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you attempted to
build/createan object whose properties containedBuffers, they would be converted from the nativeBuffertype into an array (and thus creating an incorrect value). This is caused by the use of lodash'smergeimplementation (see lodash/lodash#2964).The recommended solution from the lodash project is to define a merge
customizerto specifically handle this situation, which is what we do here.