Fix for Date usage in DeepPartial #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehanson
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Thanks for this fix!
I'm realizing that this is an issue not just for Date but also for any custom object with a constructor (eg. I get the issue with DayJs). It might be ideal for DeepPartial to be updated to account for all of those instead of just Date. In the meantime, though, this is a good improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #93
Allows objects with
Dateparams to be used in factories. Otherwise, you had to mock the entire public interface ofDate, or pass it throughassociationswhich was annoying.