Upgrade all the things #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mike-burns
commented
Apr 12, 2019
mike-burns
commented
- Gradle
- Kotlin
- target and compilation SDK
- AndroidX
- Gradle - Kotlin - target and compilation SDK - AndroidX
alexsullivan114
approved these changes
Apr 12, 2019
| @@ -24,6 +24,6 @@ fun String.colorSubString(subString: String, color: Int): SpannableStringBuilder | |||
| return stringBuilder | |||
| } | |||
|
|
|||
| fun RecyclerView.attachSnapHelper(snapHelper: SnapHelper) { | |||
| fun androidx.recyclerview.widget.RecyclerView.attachSnapHelper(snapHelper: androidx.recyclerview.widget.SnapHelper) { | |||
There was a problem hiding this comment.
I don't think this should be fully qualified, right? It makes it very noisy.
| import android.view.MotionEvent | ||
| import com.thoughtbot.tropos.scrolling.OverScroller.OverScrollDirection.END | ||
|
|
||
| class RecyclerViewScroller(override val view: RecyclerView) : Scroller { | ||
| class RecyclerViewScroller(override val view: androidx.recyclerview.widget.RecyclerView) : Scroller { |
| @@ -36,17 +36,17 @@ class RecyclerViewScroller(override val view: RecyclerView) : Scroller { | |||
|
|
|||
| } | |||
|
|
|||
| fun RecyclerView.setVerticalEndOverScroller() { | |||
| fun androidx.recyclerview.widget.RecyclerView.setVerticalEndOverScroller() { | |||
There was a problem hiding this comment.
And here but I'm going to stop commenting it now :)
| @@ -19,6 +23,10 @@ buildscript { | |||
| allprojects { | |||
| repositories { | |||
| jcenter() | |||
| maven { | |||
There was a problem hiding this comment.
You should be able to use the google() method here instead of specifying the google maven repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.