Fix nix build #290
Merged
Fix nix build #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake lock file updates:
• Updated input 'crane':
'github:ipetkov/crane/19ca94ec2d288de334ae932107816b4a97736cd8' (2024-05-26)
→ 'github:ipetkov/crane/17d9e9dedd58dde2c562a4296934c6d6a0844534' (2024-06-09)
|
I updated the crane dependency to avoid running into ipetkov/crane#631 |
LeeSmet
approved these changes
Jun 10, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nix build was building the wrong crate and was not actually building any binaries, with this change we set
sourceRootcorrectly so that we build the correct crates.The first commit is just changing how we instantiate the crane lib since we got a deprecation warning. The diff looks big because I introduced a new let binding which caused the rest of the code to get indented, but only one line actually changed.