🐛 Fix 'href' attribute error on some feeds

tibonihoo · Aug 20, 2024 · 5159ee2 · 5159ee2
1 parent ec5809d
commit 5159ee2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/wom_river/tasks.py b/wom_river/tasks.py
@@ -133,10 +133,10 @@ def get_and_patch_link(entry):
       return entry_link
     other_links = (
         [ link for link in entry.get("links", [])
-          if link.rel == "enclosure" and link.href]
+          if link.get("rel", None) == "enclosure" and link.get("href", None)]
         +
         [ link for link in entry.get("links", [])
-          if link.rel != "enclosure" and link.href]
+          if link.get("rel", None) != "enclosure" and link.get("href", None)]
         )
     if not other_links:
       return None

diff --git a/wom_river/tests.py b/wom_river/tests.py
@@ -347,6 +347,16 @@ def setUp(self):
       <!-- No pubDate -->
       <guid isPermaLink="false">123</guid>
     </item>
+    <item>
+      <title>The art</title>
+      <!-- No link but an enclosure without any url -->
+      <enclosure type="image/png" size="42"/>
+      <category>test</category>
+      <description>&lt;p>This is just a test&lt;/p>
+      </description>
+      <!-- No pubDate -->
+      <guid isPermaLink="false">123</guid>
+    </item>
   </channel>
 </rss>
 """