Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add profiling options #74

Merged
merged 3 commits into from
Apr 2, 2024
Merged

feat: add profiling options #74

merged 3 commits into from
Apr 2, 2024

Conversation

Rjected
Copy link

@Rjected Rjected commented Feb 28, 2024

Adds a subset of the profiling options. This requires the profiling feature to be enabled on tikv-jemalloc-ctl to be used.

Also adds the new macos-14 runner for the aarch64-apple-darwin target to CI.

@Rjected Rjected force-pushed the add-lg-prof-options branch 2 times, most recently from daec210 to 6f03106 Compare February 28, 2024 06:42
BusyJay
BusyJay reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only read access is needed?

jemalloc-ctl/src/profiling.rs Outdated
//! `jemalloc`'s run-time configuration for profiling-specific settings.
//!
//! These settings are controlled by the `MALLOC_CONF` environment variable.
#![cfg(feature = "profiling")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already marked in lib.rs.

Copy link
Author

@Rjected Rjected Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, removed

@Rjected
Copy link
Author

Rjected commented Mar 22, 2024

Why only read access is needed?

Jemalloc docs say the following:

opt.prof (bool) r-
opt.lg_prof_interval (ssize_t) r-
opt.lg_prof_sample (size_t) r-
opt.prof_final (bool) r-
opt.prof_leak (bool) r-

Write access would be nice, but it doesn't look like we can have write access for these opts

@Rjected
add m1 macos ci target
bffbb98 
Signed-off-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@Rjected
feat: add profiling options
6dde9d0 
Signed-off-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@Rjected
remove redundant profiling cfg
299ecd0 
Signed-off-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@BusyJay BusyJay merged commit 4f35ea8 into tikv:main Apr 2, 2024
8 of 9 checks passed
@BusyJay
Copy link
Member

BusyJay commented Apr 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @BusyJay