Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the store metrics after becoming Tombstone #7187

Closed
rleungx opened this issue Oct 10, 2023 · 0 comments · Fixed by #7186
Closed

Delete the store metrics after becoming Tombstone #7187

rleungx opened this issue Oct 10, 2023 · 0 comments · Fixed by #7186
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Oct 10, 2023 •
edited
Loading

Enhancement Task

Store statistics are updated every 10s. We rely on it to delete metrics in Prometheus. But if we remove tombstones before running the update thread. The metrics may be left in Prometheus, however, part of our tests rely on it to check.
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Oct 10, 2023
@rleungx rleungx mentioned this issue Oct 10, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Oct 11, 2023
@rleungx @ti-chi-bot
*: remove store statistics after store tombstone (#7186)
92858b7 
close #7187

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
lhy1024 pushed a commit to lhy1024/pd that referenced this issue Oct 12, 2023
@rleungx @ti-chi-bot @lhy1024
*: remove store statistics after store tombstone (tikv#7186)
e6e7c64 
close tikv#7187

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 1, 2023
@rleungx @ti-chi-bot
*: remove store statistics after store tombstone (tikv#7186)
adfa678 
close tikv#7187

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: remove store statistics after store tombstone rleungx/pd
1 participant
@rleungx