Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic change history load windows length #7877

Closed
HuSharp opened this issue Mar 5, 2024 · 0 comments · Fixed by #7878
Closed

dynamic change history load windows length #7877

HuSharp opened this issue Mar 5, 2024 · 0 comments · Fixed by #7878
Assignees
@lhy1024
Labels
affects-7.5 type/enhancement The issue or PR belongs to an enhancement.

Comments

@HuSharp
Copy link
Member

HuSharp commented Mar 5, 2024 •
edited
Loading

Enhancement Task

After the #6297 merged, we had history load limit, which meant that when detecting a hotspot, it would take us at least 5 minutes to identify the hotspot. (which started in 7.1.0, and only enabled in raftV2)

After the #6807 merged, we now use this feature without raftV2 limitations (which started in 7.5.0)

For some users who ensure their load is stable and want to start hotspot scheduling as soon as possible, perhaps we can support dynamic configuration to determine the length of the history load.
@HuSharp HuSharp added the type/enhancement The issue or PR belongs to an enhancement. label Mar 5, 2024
@lhy1024 lhy1024 mentioned this issue Mar 5, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #7878 Mar 7, 2024
ti-chi-bot bot pushed a commit that referenced this issue Mar 7, 2024
@lhy1024
scheduler: make history-sample-interval and history-sample-duration c…
bbd3bdb 
…onfigurable (#7878)

close #7877

Signed-off-by: lhy1024 <admin@liudos.us>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Mar 7, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#7878
e6c2318 
close tikv#7877

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhy1024 lhy1024

Labels
affects-7.5 type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scheduler: make history-sample-interval and history-sample-duration configurable lhy1024/pd
2 participants
@lhy1024 @HuSharp