Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil_test: close goroutine leak when block in accept #7787

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Feb 1, 2024

What problem does this PR solve?

Issue Number: Ref #7782, tested by #7777

What is changed and how does it work?

etcdutil_test: close goroutine leak when block in accept

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 1, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 February 1, 2024 07:22
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #7787 (ee95d1d) into master (cce1464) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7787      +/-   ##
==========================================
- Coverage   73.45%   73.40%   -0.06%     
==========================================
  Files         432      432              
  Lines       47843    47843              
==========================================
- Hits        35145    35118      -27     
- Misses       9654     9681      +27     
  Partials     3044     3044              
Flag Coverage Δ
unittests 73.40% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 6, 2024
@JmPotato
Copy link
Member

JmPotato commented Feb 6, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 018ede7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit f0699ba into tikv:master Feb 6, 2024
25 of 26 checks passed
@HuSharp HuSharp deleted the fix_etcd_goroutine_leak branch February 6, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants