*: reset config if the input is invalid #8632
Open
+76
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot
bot
added
release-note-none
lhy1024
reviewed
Sep 14, 2024
lhy1024
approved these changes
Sep 14, 2024
| @@ -813,6 +813,60 @@ func (suite *schedulerTestSuite) checkSchedulerDiagnostic(cluster *pdTests.TestC | |||
| checkSchedulerDescribeCommand("balance-leader-scheduler", "normal", "") | |||
| } | |||
|
|
|||
| func (suite *schedulerTestSuite) TestEvictLeaderScheduler() { | |||
| // FIXME: API mode may have the problem | |||
There was a problem hiding this comment.
Will we fix it in another PR?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8632 +/- ##
==========================================
- Coverage 77.60% 77.55% -0.05%
==========================================
Files 474 474
Lines 61893 61906 +13
==========================================
- Hits 48029 48014 -15
- Misses 10320 10338 +18
- Partials 3544 3554 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhy1024
reviewed
Sep 14, 2024
| re.Contains(string(output), "Success!") | ||
| output, err = tests.ExecuteCommand(cmd, []string{"-u", pdAddr, "scheduler", "remove", "evict-leader-scheduler"}...) | ||
| re.NoError(err) | ||
| re.Contains(string(output), "Success!") |
There was a problem hiding this comment.
Maybe we need to check
testutil.Eventually(re, func() bool { // wait for removed scheduler to be synced to scheduling server.
output := mustExec(re, cmd, []string{"-u", pdAddr, "scheduler", "config", "evict-leader-scheduler"}, nil)
return strings.Contains(output, "[404] scheduler not found")
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8619.
What is changed and how does it work?
Check List
Tests
Release note