Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider degrading log version from 0.4 to 0.3 #113

Closed
siddontang opened this issue Sep 6, 2018 · 5 comments
Closed

consider degrading log version from 0.4 to 0.3 #113

siddontang opened this issue Sep 6, 2018 · 5 comments
Labels
Bug Recognized misbehavior.

Comments

@siddontang
Copy link
Contributor

It shows Unknown for the file name in TiKV log, and hard to debug for us.

@siddontang siddontang added the Bug Recognized misbehavior. label Sep 6, 2018
@BusyJay
Copy link
Member

BusyJay commented Sep 6, 2018

I don't think it's a bug of this crate. Better let TiKV upgrade its log dependency to 0.4.

@siddontang
Copy link
Contributor Author

now, it is hard to upgrade to log 0.4 because slog doesn't support it.

@breeswish

@BusyJay
Copy link
Member

BusyJay commented Sep 6, 2018

Then it sounds like a bug of slog.

@siddontang
Copy link
Contributor Author

yes, but now we have no time to fix it for slog. So the better way is to degrade log version.

@breezewish
Copy link
Member

I don't think it's a good idea. Downgrading a dependency to an outdated version is not friendly for the community. Other people who are using this crate will suffer issues. Meanwhile, we are not meeting much trouble when raft.rs using log 0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Recognized misbehavior.
Projects
None yet
Development

No branches or pull requests

3 participants