Ease log dependency #116
Merged
Ease log dependency #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. >0.3 is a good idea! |
breezewish
reviewed
Sep 7, 2018
Cargo.toml
Outdated
| @@ -12,7 +12,7 @@ description = "The rust language implementation of Raft algorithm." | |||
| categories = ["algorithms", "database-implementations"] | |||
|
|
|||
| [dependencies] | |||
| log = "0.4" | |||
| log = ">0.3" | |||
There was a problem hiding this comment.
I took a look at the history version of log crate, seems that we can use a version as low as 0.2.0 (which already includes all necessary macros including trace!). So maybe we can ease more to >= 0.2.0?
Hoverbear
force-pushed
the
ease-log-dep
branch
from
1e6a7e2
to
f45c096
Compare
breezewish
approved these changes
Sep 7, 2018
|
So if log 0.5 breaks again, we need another PR to fix it? 🤣 |
|
@BusyJay we don't need to publish a new version if log 0.5 published, as long as info!, trace! and so on interfaces are not changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113