Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Votes should be updated when doing conf change #221

Closed
BusyJay opened this issue Apr 19, 2019 · 2 comments
Closed

Votes should be updated when doing conf change #221

BusyJay opened this issue Apr 19, 2019 · 2 comments
Assignees
@BusyJay
Labels
Bug Recognized misbehavior.
Milestone
0.6.0

Comments

@BusyJay
Copy link
Member

BusyJay commented Apr 19, 2019

If conf change remove a node, its vote should also be removed. Otherwise we can get the wrong number of agree votes and lead to an election failure.
@BusyJay
Copy link
Member Author

BusyJay commented Apr 19, 2019

And poll method should be called again after applying conf change in case quorum is met.

@BusyJay
Copy link
Member Author

BusyJay commented Apr 19, 2019

Turns out the bug is caused by incorrectly campaign when receiving MsgTimeoutNow. All campaign should check if there is any unapplied conf changes.

/cc @xiang90

@Hoverbear Hoverbear added the Bug Recognized misbehavior. label Apr 23, 2019
@Hoverbear Hoverbear added this to the 0.6.0 milestone Apr 23, 2019
@BusyJay BusyJay mentioned this issue Apr 28, 2019
Merged
@BusyJay BusyJay self-assigned this Apr 28, 2019
BusyJay added a commit that referenced this issue Apr 29, 2019
@BusyJay
Check pending conf change before campaign (#225)
64571f0 
Fix #221.
@BusyJay BusyJay closed this as completed Apr 29, 2019
@BusyJay BusyJay mentioned this issue Apr 29, 2019
Merged
hicqu pushed a commit to hicqu/raft-rs that referenced this issue Jul 17, 2019
@BusyJay @hicqu
Check pending conf change before campaign (tikv#225)
813fc4e 
Fix tikv#221.
Hoverbear pushed a commit that referenced this issue Jul 19, 2019
@hicqu @Hoverbear
Cherry pick all 0.4.x (#263)
1377cb6 
* Check pending conf change before campaign (#225)

Fix #221.

* Add more convenient lite-weight interfaces (#227)

This PR introduces two simple and lite weight interfaces:
- ping to trigger heartbeats without ticking,
- status_ref to borrow the progress set instead of cloning.

* *: bump to 0.4.2 (#228)

* Bump to v0.4.3 (#231)

* raft: leader respond to learner read index message (#220)

Signed-off-by: nolouch <nolouch@gmail.com>

* Bump to v0.4.3

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Request snapshot (#243)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* fix tests

* cargo fmt

* address comments.
@BusyJay BusyJay mentioned this issue Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BusyJay BusyJay

Labels
Bug Recognized misbehavior.
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@Hoverbear @BusyJay