Introduce benchmarking using Criterion. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
force-pushed
the
add-benches
branch
8 times, most recently
from
a0238b0
to
58246d2
Compare
siddontang
reviewed
Aug 28, 2018
benches/benches.rs
Outdated
| mod suites; | ||
| use suites::*; | ||
|
|
||
| criterion_main!( |
There was a problem hiding this comment.
the default sample size for the criterion is 100, maybe we can use a smaller sample size like 10 to reduce the benchmark time.
|
CI failed @Hoverbear |
Hoverbear
force-pushed
the
add-benches
branch
4 times, most recently
from
cea2462
to
75625ba
Compare
Hoverbear
force-pushed
the
add-benches
branch
2 times, most recently
from
e9a2340
to
ecc28dd
Compare
|
PTAL @breeswish |
|
LGTM |
breezewish
reviewed
Sep 5, 2018
benches/benches.rs
Outdated
|
|
||
| fn main() { | ||
| criterion::init_logging(); | ||
| let _ = env_logger::try_init(); |
There was a problem hiding this comment.
Seems to be duplicated? criterion::init_logging will use a SimpleLogger to initialize log.
Hoverbear
force-pushed
the
add-benches
branch
from
ecc28dd
to
c6dc9d7
Compare
|
@breeswish Thanks, I resolved your comment. PTAL again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts on #109.
This demonstrates Criterion, ways to bench cleanly, and documentation how to use it.