Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch split #6

Merged
merged 15 commits into from
Dec 20, 2018
Merged

Add batch split #6

merged 15 commits into from
Dec 20, 2018

Conversation

Connor1996
Copy link
Member

No description provided.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

PTAL @tikv/pingcap-i18n @zhangjinpeng1987 @siddontang

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@QueenyJin
Copy link

@lilin90 PTAL.

text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
text/2018-10-25-batch-split.md Outdated Show resolved Hide resolved
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Hoverbear Hoverbear added the Migrated RFC This RFC was accepted before this repo existed and/or TiKV entered the CNCF. It is already accepted. label Nov 14, 2018
@siddontang siddontang mentioned this pull request Nov 14, 2018
21 tasks
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

PTAL again

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, I think the writing is good :)


## Implementation in TiKV

### How to produce multiple split keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not overspecify the details in the RFC as doing so can bury the reviewer in minutiae.

IMO, this section is too detailed and not necessary.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

PTAL again @huachaohuang

general logic of SizeChecker and KeysChecker are similar. The only difference
between them is one splits Region based on size and the other splits Region
based on the number of keys. So here we mainly describe the logic of
SizeChecker:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think the following two paragraphs are too verbose and not necessary.
These explanations are more suitable as comments in the code than in the RFC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the algorithm should discussed in RFC stage.

Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang
Copy link
Contributor

@Connor1996 Try to get another approval :)

@Connor1996
Copy link
Member Author

PTAL @zhangjinpeng1987

Signed-off-by: Hoverbear <operator@hoverbear.org>
@Hoverbear Hoverbear merged commit f1f14fc into master Dec 20, 2018
@Hoverbear Hoverbear deleted the Connor1996-patch-1 branch December 20, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrated RFC This RFC was accepted before this repo existed and/or TiKV entered the CNCF. It is already accepted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants