*: check region epoch strictly #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
added
sig/raft
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
Please fix conflicts |
|
Please refer to the related kvproto PR |
Connor1996
reviewed
Jan 28, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
@Connor1996 It is reproduced in test_split_epoch_not_match. |
|
/release |
|
PTAL, thanks! |
|
any update about this and corresponding other PRs? |
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests tidb=release-2.1 pd=release-2.1 tidb-test=release-2.1 |
|
/release |
|
There seems to be no case about the situation you describe. |
|
There is a test case covers the situation https://github.com/tikv/tikv/pull/4125/files#diff-87d8831b47ad20a68a88901c547ce300R628. It sends a requests with a newer epoch and get a key which is out of the region. @BusyJay |
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Feb 26, 2019
Checks region epoch strictly to avoid KeyNotInRegion errors. A 3 nodes TiKV cluster with merge enabled, after commit merge, TiKV A tells TiDB with a epoch not match error contains the latest target Region info, TiDB updates its region cache and sends requests to TiKV B, and TiKV B has not applied commit merge yet, since the region epoch in request is higher than TiKV B, the request must be denied due to epoch not match, so it does not read on a stale snapshot, thus avoid the KeyNotInRegion error. Signed-off-by: Neil Shen <overvenus@gmail.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Checks region epoch strictly to avoid KeyNotInRegion errors. A 3 nodes TiKV cluster with merge enabled, after commit merge, TiKV A tells TiDB with a epoch not match error contains the latest target Region info, TiDB updates its region cache and sends requests to TiKV B, and TiKV B has not applied commit merge yet, since the region epoch in request is higher than TiKV B, the request must be denied due to epoch not match, so it does not read on a stale snapshot, thus avoid the KeyNotInRegion error. Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
Checks region epoch strictly to avoid KeyNotInRegion errors.
A 3 nodes TiKV cluster with merge enabled, after commit merge, TiKV A
tells TiDB with a epoch not match error contains the latest target Region
info, TiDB updates its region cache and sends requests to TiKV B,
and TiKV B has not applied commit merge yet, since the region epoch in
request is higher than TiKV B, the request must be denied due to epoch
not match, so it does not read on a stale snapshot, thus avoid the
KeyNotInRegion error.
What are the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Integrations tests
Does this PR affect documentation (docs) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Cc pingcap/kvproto#344