*: add metrics for unified read pool #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sticnarf
added
type/enhancement
sticnarf
changed the title
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
yatp-metrics
branch
from
e1b4606
to
60dc268
Compare
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
| @@ -61,3 +68,88 @@ lazy_static! { | |||
| ) | |||
| .unwrap(); | |||
| } | |||
|
|
|||
| pub struct CopLocalMetrics { | |||
There was a problem hiding this comment.
Why not move it to src/coprocessor/local_metrics.rs?
There was a problem hiding this comment.
Oh, I found src/coprocessor/local_metrics.rs is never used..
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
This was referenced Feb 13, 2020
andylokandy
reviewed
Feb 13, 2020
src/read_pool.rs
Outdated
| inner, | ||
| } | ||
| } | ||
|
|
||
| // Only flush metrics by tick | ||
| fn maybe_flush_metrics(&self) { |
There was a problem hiding this comment.
Would try_flush_metrics be better?
There was a problem hiding this comment.
try_ usually returns a Result while here we just ignore too frequent flushes
There was a problem hiding this comment.
fixed. PTAL again.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
yatp-metrics
branch
from
e402f79
to
29099f8
Compare
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
With these metrics we can see how the multilevel thread pool is scheduling small and big requests:
What is the type of the changes?
How is the PR tested?
Metrics are now available.
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No