Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: consider wake-up msg when checking stale msg in peer fsm (#7592) #7598

Merged
merged 5 commits into from
Apr 21, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 21, 2020

cherry-pick #7592 to release-3.0


Signed-off-by: Liqi Geng gengliqiii@gmail.com

What problem does this PR solve?

Problem Summary:
In #7416, we check wake-up msg in store fsm, this logic will be triggered only when the asked peer has already destroyed. But if the asked peer exists, it will ignore the wake-up msg and the problem is similar to #7416.
Although the learner who sends wake-up msg can be destroyed after querying to PD in this case, it needs several minutes which is too slow.

What is changed and how it works?

What's Changed:
Do not ignore the wake-up msg in peer fsm.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

No

Release note

Using the same release note as #7416

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

@sre-bot sre-bot added sig/raft Component: Raft, RaftStore, etc. type/bugfix This PR fixes a bug. type/cherry-pick Type: PR - Cherry pick labels Apr 21, 2020
@sre-bot sre-bot added this to the v3.0.13 milestone Apr 21, 2020
@AndreMouche
Copy link
Member

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

Your auto merge job has been accepted, waiting for:

  • 7597

Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

@sre-bot merge failed.

@youjiali1995
Copy link
Contributor

/merge

@gengliqi
Copy link
Member

/run-all-tests

Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
@AndreMouche
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 21, 2020

Your auto merge job has been accepted, waiting for:

  • 7584
  • 7605