util: support float cgroup cpu quota (#8425) #8427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/configuration
BusyJay
approved these changes
Aug 11, 2020
5kbpers
approved these changes
Aug 31, 2020
ti-srebot
added
status/LGT2
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-integration-common-test |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/test |
1 similar comment
|
/test |
sticnarf
added
the
priority/release-blocker
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8425 to release-4.0
What problem does this PR solve?
Issue Number: close #8423
Problem Summary:
The CPU quota set in cgroup can be an arbitrary float but we don't handle it. TiKV considers the CPU quota is 0 if the quota is less than 1.
What is changed and how it works?
What's Changed:
Let
cpu_cores_quotajust return anf64and change calculations just use the float cpu quota.Coprocessor max_concurrency is also set to not less than 4. Such a number should not cause OOM.
Related changes
Check List
Tests
Manual test (add detailed scripts or steps below)
end_point_max_concurrencywill be at least 4.Release note
Support float CPU quota in cgroup.