Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TransitionAbort to builder interface #309

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Refactor TransitionAbort to builder interface #309

merged 1 commit into from
Nov 10, 2020

Conversation

rwjblue
Copy link
Collaborator

@rwjblue rwjblue commented Nov 6, 2020 •
edited
Loading

Migrate TransitionAbortedError to builder + interface.

TODO:

@rwjblue rwjblue force-pushed the absorb-transition-aborted branch 2 times, most recently from b43c1e3 to 3a216a8 Compare November 9, 2020 15:03
@rwjblue rwjblue marked this pull request as ready for review November 9, 2020 15:04
@rwjblue @stefanpenner
Migrate TransitionAbortedError to builder + interface.
38f4ca2 
* Avoid trying to manually extend from a native error, instead use a
normal `Error` and add our name/code to it.
* introduce structurally Abortable concept
@rwjblue rwjblue merged commit f889135 into master Nov 10, 2020
@rwjblue rwjblue deleted the absorb-transition-aborted branch November 10, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanpenner stefanpenner stefanpenner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @stefanpenner