Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zerocopy dependency has a license incompatible with the crate itself #176

Closed
zesterer opened this issue Oct 24, 2023 · 8 comments · Fixed by #177
Closed

zerocopy dependency has a license incompatible with the crate itself #176

zesterer opened this issue Oct 24, 2023 · 8 comments · Fixed by #177

Comments

@zesterer
Copy link

This was found by cargo-deny in amethyst/specs#770.

zerocopy has the license string BSD-2-Clause, but ahash has MIT OR Apache-2.0. The former is incompatible with the latter.

Although this isn't in itself a fundamental problem, it does mean that the de-facto license that users of ahash are operating under is BSD-2-Clause, which is less permissive and not suitable for some purposes.

@tkaitchuck
Copy link
Owner

@joshlf It looks like I am going to have to revert #162

@joshlf
Copy link
Contributor

joshlf commented Oct 24, 2023

@tkaitchuck I should be able to re-license; we've been considering doing this anyway. If I were to re-license and publish, would you be able to use the new release?

@tkaitchuck
Copy link
Owner

tkaitchuck commented Oct 24, 2023

Yes. To clarify, what sort of timeline are you looking at?

@joshlf
Copy link
Contributor

joshlf commented Oct 24, 2023

Yes. To clarify, what sort of timeline are you looking at?

I should be able to do it today; would that work for you?

@tkaitchuck
Copy link
Owner

Yes, that's great

joshlf added a commit to google/zerocopy that referenced this issue Oct 24, 2023
Release under the existing license (BSD-style, 2-clause) and under MIT
and Apache 2.0.

Release 0.7.13.

Unblocks tkaitchuck/aHash#176
joshlf added a commit to google/zerocopy that referenced this issue Oct 24, 2023
Release under the existing license (BSD-style, 2-clause) and under MIT
and Apache 2.0.

Release 0.7.13.

Unblocks tkaitchuck/aHash#176
@joshlf
Copy link
Contributor

joshlf commented Oct 24, 2023

Does this look like it'll work for you? google/zerocopy#542

joshlf added a commit to google/zerocopy that referenced this issue Oct 24, 2023
Release under the existing license (BSD-style, 2-clause) and under MIT
and Apache 2.0.

Release 0.7.13.

Unblocks tkaitchuck/aHash#176
joshlf added a commit to google/zerocopy that referenced this issue Oct 24, 2023
Release under the existing license (BSD-style, 2-clause) and under MIT
and Apache 2.0.

Release 0.7.13.

Unblocks tkaitchuck/aHash#176
joshlf added a commit to google/zerocopy that referenced this issue Oct 24, 2023
Release under the existing license (BSD-style, 2-clause) and under MIT
and Apache 2.0.

Release 0.7.13.

Unblocks tkaitchuck/aHash#176
joshlf added a commit to google/zerocopy that referenced this issue Oct 24, 2023
Release under the existing license (BSD-style, 2-clause) and under MIT
and Apache 2.0.

Release 0.7.14.

Unblocks tkaitchuck/aHash#176
@joshlf
Copy link
Contributor

joshlf commented Oct 24, 2023

Published 0.7.14 with these changes. Lmk if this fixes the problem.

@zesterer
Copy link
Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants