Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] tabs in text exports #1323

Merged
merged 3 commits into from
May 11, 2023
Merged

[fix] tabs in text exports #1323

merged 3 commits into from
May 11, 2023

Conversation

steveruizok
Copy link
Collaborator

@steveruizok steveruizok commented May 5, 2023 •
edited
Loading

This PR fixes the appearance of tabs in labels and text when exporting images.

This involved refactoring our CSS-text-to-multiline-SVG-text.

Test Plan

  1. Create a text or geo shape with a label that includes a tab character at the beginning of a line (e.g. jsx)
  2. Copy the image as SVG and paste

Release Note

  • Fixes a bug with trailing tab characters in text labels on image export

@vercel
Copy link

vercel bot commented May 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview May 7, 2023 6:23pm
tldraw-docs-staging ✅ Ready (Inspect) Visit Preview May 7, 2023 6:23pm

@steveruizok steveruizok requested a review from TodePond May 5, 2023 16:17
TodePond
TodePond requested changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@TodePond TodePond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing an issue with this. That's a weird one!

Screenshot 2023-05-05 at 17 25 28

@steveruizok steveruizok requested a review from TodePond May 7, 2023 10:44
@steveruizok
Copy link
Collaborator Author

steveruizok commented May 7, 2023 •
edited
Loading

Should be all fixed now!

image

TodePond
TodePond approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@TodePond TodePond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work now!

@steveruizok steveruizok added this pull request to the merge queue May 11, 2023
@steveruizok steveruizok added the needs qa Tag a pull request as needing to be manually QA'd before release label May 11, 2023
Merged via the queue into main with commit dfaa536 May 11, 2023
@steveruizok steveruizok deleted the fix-space-exports branch May 11, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TodePond TodePond TodePond approved these changes

Assignees
No one assigned
Labels
needs qa Tag a pull request as needing to be manually QA'd before release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveruizok @TodePond