shapes folder, move tools into shape defs #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SomeHats
force-pushed
the
alex/tools-in-shapes
branch
from
5307b7e
to
5e25fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds a new property to
defineShape:tool.The tool prop allows shapes to bring a tool along with them as part of their definition. E.g. the draw shape isn't much use without the draw tool, so adding the draw shape to your app gives you the draw tool tool.
As part of this, i renamed the
shapeutilsfolder to justshapes, and moved a bunch of shape-specific tools from the tools folder into the shapes folder. This more closely reflects how things will be once we move our default shapes out of core for tldraw-zero.Change Type
patch— Bug fixTest Plan
Tested locally
Release Notes
n/a