Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video shape controls #1909

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix video shape controls #1909

merged 1 commit into from
Sep 18, 2023

Conversation

ds300
Copy link
Collaborator

@ds300 ds300 commented Sep 18, 2023

The video shape was not interactive in it's editing mode, so I just updated it to have pointer-events: all when editing.

closes #1908

Change Type

  • patch — Bug fix
  • minor — New feature
  • major — Breaking change
  • dependencies — Changes to package dependencies1
  • documentation — Changes to the documentation only2
  • tests — Changes to any test code only2
  • internal — Any other changes that don't affect the published package2
  • I don't know

Test Plan

  1. Add a step-by-step description of how to test your PR here.
  • Unit Tests
  • End to end tests

Release Notes

  • Fixes pointer events for editing video shapes.

Footnotes

  1. publishes a patch release, for devDependencies use internal

  2. will not publish a new version 2 3

@huppy-bot huppy-bot bot added the bugfix Bug fix label Sep 18, 2023
@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Sep 18, 2023 2:00pm

@ds300 ds300 added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 5458362 Sep 18, 2023
6 checks passed
@ds300 ds300 deleted the david/fix-video-controls branch September 18, 2023 14:40
@steveruizok
Copy link
Collaborator

Looks good!

@leolorenzoluis
Copy link

leolorenzoluis commented Sep 24, 2023

@steveruizok I do want to point out that staging/tldraw prod does not have the bug of seeking. It did have a different type of css class name compared to latest one. One was able to seek in the player, but now it's not doable with latest, but then the difference could be tldraw is saving it as a file so seeking is possible, but if it's external assets then no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't interact with controls on editing video
3 participants