Fix line wobble #1915
Merged
Fix line wobble #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
This is a follow up to #1915 which caused the shape container div dimensions to be wildly inaccurate. We thought it wouldn't matter but we had a note on discord from someone who was relying on the div container being accurate. This rounds the shape dimensions to the nearest integer that is compatible with the user's device pixel ratio, using the method pioneered in #1858 (thanks @BrianHung) ### Change Type - [x] `patch` — Bug fix - [ ] `minor` — New feature - [ ] `major` — Breaking change - [ ] `dependencies` — Changes to package dependencies[^1] - [ ] `documentation` — Changes to the documentation only[^2] - [ ] `tests` — Changes to any test code only[^2] - [ ] `internal` — Any other changes that don't affect the published package[^2] - [ ] I don't know [^1]: publishes a `patch` release, for devDependencies use `internal` [^2]: will not publish a new version ### Release Notes - Improves the precision of the shape dimensions rounding logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1911
Change Type
patch— Bug fixminor— New featuremajor— Breaking changedependencies— Changes to package dependencies1documentation— Changes to the documentation only2tests— Changes to any test code only2internal— Any other changes that don't affect the published package2Test Plan
Release Notes
Footnotes
publishes a
patchrelease, for devDependencies useinternal↩will not publish a new version ↩ ↩2 ↩3