Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove targeted editing from text #1962

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Remove targeted editing from text #1962

merged 7 commits into from
Sep 29, 2023

Conversation

TodePond
Copy link
Collaborator

@TodePond TodePond commented Sep 28, 2023

This PR has been tested on Mac Chrome, iOS Safari, and Android Chrome.


This PR removes 'targeted editing' from text.
This affects when you're:

  • using the text tool
  • editing a text shape
  • editing a text label
  • editing an arrow label

When in one of these modes, you were able to click on some other text to immediately start editing it (as long as that text is the same type).

It was a bit broken with some of the newer changes, so this PR removes it. The issues included:

  • selected text 'flashing'
  • caret going to the start of the text
  • empty text shapes not disappearing
  • inconsistent behaviour when clicking near a shape VS on a shape

It feels a bit simpler now too, I like it... 🤔💭

2023-09-28 at 15 36 15 - Beige Parrotfish

Change Type

  • patch — Bug fix

Test Plan

  • Unit Tests
  • End to end tests

Release Notes

  • Fixed some cases where text would get selected in the wrong place.
  • Changed the behaviour of text selection. Removed 'deep editing'.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Sep 29, 2023 3:58pm

@TodePond TodePond marked this pull request as ready for review September 28, 2023 11:48
@huppy-bot huppy-bot bot added the bugfix Bug fix label Sep 28, 2023
@TodePond TodePond changed the title Remove targeted editing from text tool Remove targeted editing from text Sep 28, 2023
@TodePond TodePond marked this pull request as draft September 28, 2023 13:50
@TodePond TodePond marked this pull request as ready for review September 28, 2023 14:39
@TodePond TodePond added major Increment the major version when merged and removed bugfix Bug fix labels Sep 29, 2023
Merged via the queue into main with commit b149fe7 Sep 29, 2023
4 checks passed
@steveruizok steveruizok deleted the lu/label-auto-select branch September 29, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants