Change Choice.shortcut_key to property with setter
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overhacked
force-pushed
the
auto_shortcut_loop_fix
branch
2 times, most recently
from
40ef821
to
8f4ab05
Compare
|
@kiancross, I implemented the fix you suggested in #340: #340 (comment). Checking in about whether it is possible to merge this? Thanks! |
|
@overhacked Please can you update this branch with latest changes from |
overhacked
force-pushed
the
auto_shortcut_loop_fix
branch
from
8f4ab05
to
c333dec
Compare
|
Up to date now. I ran lints and tests before pushing; hopefully CI passes 🤞. |
kiancross
reviewed
Jul 17, 2024
There was a problem hiding this comment.
@overhacked Does some logic need to be added for when auto_shortcut is changed?
Ensures that `Choice.auto_shortcut` is set to `False` whenever `Choice.shortcut_key` is set to a `str` value and vice versa. Add tests for fix. Fixes tmbo#340 Signed-off-by: Ross Williams <ross@ross-williams.net>
`auto_shortcut` and `shortcut_key` interact in ways that requires logic when setting either, to ensure that they do not conflict. Signed-off-by: Ross Williams <ross@ross-williams.net>
overhacked
force-pushed
the
auto_shortcut_loop_fix
branch
from
c333dec
to
a92cea9
Compare
|
@kiancross, you're right. I added code to handle blanking |
kiancross
approved these changes
Jul 23, 2024
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Ensures that
Choice.auto_shortcutis set toFalsewheneverChoice.shortcut_keyis set to astrvalue and vice versaCloses #340
How did you solve it?
Implemented the suggested fix in PR #340 to convert
Choices.shortcut_keyto a property with a setter.Checklist