Goodie bag of small changes #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a look at the failed test runs. One is because of the updated rake dependency. |
|
I fixed one failure, but one is remaining, see here. But I'm at a loss why this would only fail on Ruby 2.3. Any thoughts? |
|
The error here (in docker) is the same as when running it on Travis directly (see #118) with Ruby 2.3. #118: https://travis-ci.org/tmm1/stackprof/jobs/592988044#L290-L292 |
Ooh, a goodie bag! I think the owner of this repo should add you as a collaborator so you can help maintain it and merge some of these PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor changes, each in a separate commit so I can easily remove them if they are not wanted.
Unrelated to this PR, but as for the CI, I saw #116, which looks very nice since it actually works :D, but is the added runtime for CI and complexity (debatable) something that's wanted? I get the frustration with ruby-head, but then again, it's a
HEADversion — can't this be in the allowed-failures until 2.7 is officially released or Travis CI starts working again?A compromise could also be to use a separate build step for ruby-head and use Travis CI for everything else. https://docs.travis-ci.com/user/build-stages/define-steps/
WDYT?