Skip to content

Commit

Permalink
style: Remove needless borrow (#1122)
Browse files Browse the repository at this point in the history
`cargo clippy` reports:
```
warning: the borrowed expression implements the required traits
   --> protobuf/build.rs:143:14
    |
143 | ...rg(&format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display(...
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
```
  • Loading branch information
caspermeijn committed Aug 16, 2024
1 parent 7670f42 commit 409b932
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:


env:
PROTOC_VERSION: 3.20.3
clippy_rust_version: 1.79
PROTOC_VERSION: '3.20.3'
clippy_rust_version: '1.79'

jobs:
# Depends on all actions that are required for a "successful" CI run.
Expand Down
2 changes: 1 addition & 1 deletion protobuf/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ fn install_conformance_test_runner(
.arg("-GNinja")
.arg(src_dir.join("cmake"))
.arg("-DCMAKE_BUILD_TYPE=DEBUG")
.arg(&format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display()))
.arg(format!("-DCMAKE_INSTALL_PREFIX={}", prefix_dir.display()))
.arg("-Dprotobuf_BUILD_CONFORMANCE=ON")
.arg("-Dprotobuf_BUILD_TESTS=OFF")
.current_dir(build_dir)
Expand Down

0 comments on commit 409b932

Please sign in to comment.