chore: replace ready! with std::task::ready #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokio's MSRV now supports the std::task:ready macro. So the tokio ready! macro can be replaced with that.
github-actions
bot
added
R-loom-current-thread
|
I missed importing std::task::ready in a few different places. Going to try find a comprehensive way to find all the places and fix tomorrow. |
|
The changes you have so far look good. Let me know when you've replaced all of them. |
|
I also replaced tokio-stream's read macro. Also replaced future::ready and future_core::ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokio's MSRV now supports the std::task:ready macro. So the tokio ready! macro can be replaced with that.
Motivation
Tokio's MSRV is 1.70.0. std::task::ready! was introduced in 1.64.0 and has identical implementation to tokio's ready! macro.
std::task::ready! can be used instead.
Thanks @mox692 for suggesting this change!
Solution
This PR removes the tokio ready! and replaces it with std::task:ready!