Skip to content

Commit

Permalink
appender: name spawned thread (#2219)
Browse files Browse the repository at this point in the history
## Motivation

I find it useful when debugging applications with lots of threads to
easily identity them by their names.

## Solution

Just name the thread as other crates such as `sentry-rust` are doing.

Co-authored-by: Guillaume Desmottes <guillaume@desmottes.be>
  • Loading branch information
gdesmott and gdesmott committed Jul 13, 2022
1 parent 8cf8175 commit edc5607
Showing 1 changed file with 16 additions and 13 deletions.
29 changes: 16 additions & 13 deletions tracing-appender/src/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,23 @@ impl<T: Write + Send + Sync + 'static> Worker<T> {

/// Creates a worker thread that processes a channel until it's disconnected
pub(crate) fn worker_thread(mut self) -> std::thread::JoinHandle<()> {
thread::spawn(move || {
loop {
match self.work() {
Ok(WorkerState::Continue) | Ok(WorkerState::Empty) => {}
Ok(WorkerState::Shutdown) | Ok(WorkerState::Disconnected) => {
drop(self.writer); // drop now in case it blocks
let _ = self.shutdown.recv();
return;
}
Err(_) => {
// TODO: Expose a metric for IO Errors, or print to stderr
thread::Builder::new()
.name("tracing-appender".to_string())
.spawn(move || {
loop {
match self.work() {
Ok(WorkerState::Continue) | Ok(WorkerState::Empty) => {}
Ok(WorkerState::Shutdown) | Ok(WorkerState::Disconnected) => {
drop(self.writer); // drop now in case it blocks
let _ = self.shutdown.recv();
return;
}
Err(_) => {
// TODO: Expose a metric for IO Errors, or print to stderr
}
}
}
}
})
})
.expect("failed to spawn `tracing-appender` non-blocking worker thread")
}
}

0 comments on commit edc5607

Please sign in to comment.