fix: log level filter with trace #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Sep 10, 2021
hawkw
added a commit
that referenced
this pull request
Sep 11, 2021
Merged
hawkw
added a commit
that referenced
this pull request
Sep 11, 2021
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Sep 15, 2021
Summary: This includes recent changes: - `skip_all` in #[instrument] tokio-rs/tracing#1548 - NoSubscriber no-op Subscriber tokio-rs/tracing#1549 - Box/Arc Layer (tokio-rs/tracing#1536 + tokio-rs/tracing#1547) - log filtering fixes tokio-rs/tracing#1543 Local: force `log` and `log-always` features off. This removes the `enable-trace-logging` flag from smartplatform/reconciler. Reviewed By: guswynn Differential Revision: D30906032 fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Sep 15, 2021
Summary: This includes recent changes: - `skip_all` in #[instrument] tokio-rs/tracing#1548 - NoSubscriber no-op Subscriber tokio-rs/tracing#1549 - Box/Arc Layer (tokio-rs/tracing#1536 + tokio-rs/tracing#1547) - log filtering fixes tokio-rs/tracing#1543 Local: force `log` and `log-always` features off. This removes the `enable-trace-logging` flag from smartplatform/reconciler. Reviewed By: guswynn Differential Revision: D30906032 fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Sep 15, 2021
Summary: This includes recent changes: - `skip_all` in #[instrument] tokio-rs/tracing#1548 - NoSubscriber no-op Subscriber tokio-rs/tracing#1549 - Box/Arc Layer (tokio-rs/tracing#1536 + tokio-rs/tracing#1547) - log filtering fixes tokio-rs/tracing#1543 Local: force `log` and `log-always` features off. This removes the `enable-trace-logging` flag from smartplatform/reconciler. Reviewed By: guswynn Differential Revision: D30906032 fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot
pushed a commit
to facebookincubator/antlir
that referenced
this pull request
Sep 15, 2021
Summary: This includes recent changes: - `skip_all` in #[instrument] tokio-rs/tracing#1548 - NoSubscriber no-op Subscriber tokio-rs/tracing#1549 - Box/Arc Layer (tokio-rs/tracing#1536 + tokio-rs/tracing#1547) - log filtering fixes tokio-rs/tracing#1543 Local: force `log` and `log-always` features off. This removes the `enable-trace-logging` flag from smartplatform/reconciler. Reviewed By: guswynn Differential Revision: D30906032 fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Sep 15, 2021
Summary: This includes recent changes: - `skip_all` in #[instrument] tokio-rs/tracing#1548 - NoSubscriber no-op Subscriber tokio-rs/tracing#1549 - Box/Arc Layer (tokio-rs/tracing#1536 + tokio-rs/tracing#1547) - log filtering fixes tokio-rs/tracing#1543 Local: force `log` and `log-always` features off. This removes the `enable-trace-logging` flag from smartplatform/reconciler. Reviewed By: guswynn Differential Revision: D30906032 fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
hawkw
added a commit
that referenced
this pull request
Apr 21, 2022
# 0.1.3 (April 21st, 2022) ### Added - **log-tracer**: Added `LogTracer::with_interest_cache` to enable a limited form of per-record `Interest` caching for `log` records ([#1636]) ### Changed - Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913]) ### Fixed - **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level filters ([#1543]) - Broken links in documentation ([#2068], [#2077]) Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for contributing to this release! [#1636]: https://github.com/tokio-rs/tracing/pulls/1636 [#1913]: https://github.com/tokio-rs/tracing/pulls/1913 [#1543]: https://github.com/tokio-rs/tracing/pulls/1543 [#2068]: https://github.com/tokio-rs/tracing/pulls/2068 [#2077]: https://github.com/tokio-rs/tracing/pulls/2077
hawkw
added a commit
that referenced
this pull request
Apr 21, 2022
# 0.1.3 (April 21st, 2022) ### Added - **log-tracer**: Added `LogTracer::with_interest_cache` to enable a limited form of per-record `Interest` caching for `log` records ([#1636]) ### Changed - Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913]) ### Fixed - **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level filters ([#1543]) - Broken links in documentation ([#2068], [#2077]) Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for contributing to this release! [#1636]: https://github.com/tokio-rs/tracing/pulls/1636 [#1913]: https://github.com/tokio-rs/tracing/pulls/1913 [#1543]: https://github.com/tokio-rs/tracing/pulls/1543 [#2068]: https://github.com/tokio-rs/tracing/pulls/2068 [#2077]: https://github.com/tokio-rs/tracing/pulls/2077 Fixes #1884 Fixes #1664
vkill
pushed a commit
to bk-rs/fbthrift-git-rs
that referenced
this pull request
Jan 12, 2023
Summary: This includes recent changes: - `skip_all` in #[instrument] tokio-rs/tracing#1548 - NoSubscriber no-op Subscriber tokio-rs/tracing#1549 - Box/Arc Layer (tokio-rs/tracing#1536 + tokio-rs/tracing#1547) - log filtering fixes tokio-rs/tracing#1543 Local: force `log` and `log-always` features off. This removes the `enable-trace-logging` flag from smartplatform/reconciler. Reviewed By: guswynn Differential Revision: D30906032 fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.3 (April 21st, 2022) ### Added - **log-tracer**: Added `LogTracer::with_interest_cache` to enable a limited form of per-record `Interest` caching for `log` records ([tokio-rs#1636]) ### Changed - Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([tokio-rs#1913]) ### Fixed - **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level filters ([tokio-rs#1543]) - Broken links in documentation ([tokio-rs#2068], [tokio-rs#2077]) Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for contributing to this release! [tokio-rs#1636]: https://github.com/tokio-rs/tracing/pulls/1636 [tokio-rs#1913]: https://github.com/tokio-rs/tracing/pulls/1913 [tokio-rs#1543]: https://github.com/tokio-rs/tracing/pulls/1543 [tokio-rs#2068]: https://github.com/tokio-rs/tracing/pulls/2068 [tokio-rs#2077]: https://github.com/tokio-rs/tracing/pulls/2077 Fixes tokio-rs#1884 Fixes tokio-rs#1664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LogTracer::init()will convert all logs to tracing events, and regardless of the tracingCollectorfilter, just dispatch all events, cause inconsistent behavior between log and trace.